On Mon, Jul 12, 2021 at 8:21 PM Ralf Habacker <ralf.habac...@freenet.de> wrote:
> Am 12.07.21 um 09:35 schrieb Ralf Habacker: > > > >> The fact that you have to apply additional overrides here indicates to > >> me that your changes to 'kdewin' are also incorrect. > > > > It may also be caused by the kdelibs4support package, as I initial > > stated - I double checked in kdewin git repo, that it exports the > > correct header and library functions. > > > > At https://build.kde.org/job/Administration/job/Dependency Build > Extragear stable-kf5-qt5 .15/55/consoleFull you can see > > 13:57:34 -- Looking for inet_pton > 13:57:34 -- Looking for inet_pton - not found > 13:57:34 -- Looking for inet_ntop > 13:57:34 -- Looking for inet_ntop - not found > > that cmake does not find inet_ ... function, which *are* available by > msvc compiler since Windows Vista > ( > https://docs.microsoft.com/en-us/windows/win32/api/ws2tcpip/nf-ws2tcpip-inet_pton > ) > That makes sense - guess it was fixed in the newer Frameworks but never in kdelibs4support due to it's legacy nature. > > I guess using the same approach as done now in kdewin at > > https://invent.kde.org/packaging/kdewin/-/merge_requests/1/diffs?commit_id=e7ba87c10528b71ec53865c661dd718447494591#a9f1c36d35a73bf675ad0d1641cad7d3df55284e_27_28 > > should fix that issue. My earlier mentioned comment related to add the > -DHAVE_INET_PTON and -DHAVE_INET_NTOP is a valid workaround. > It would be preferrable to fix things correctly I think. Please note that I don't have a developer setup, so i'm unable to prepare/test such a patch. > Regards > Ralf > Thanks, Ben >> > >>> > >>> ---------- Forwarded message --------- > >>> From: *CI System* <nore...@kde.org <mailto:nore...@kde.org>> > >>> Date: Sat, Jul 10, 2021 at 7:21 AM > >>> Subject: KDE CI: Administration » Dependency Build Applications > >>> stable-kf5-qt5 WindowsMSVCQt5.15 - Build # 52 - Still Failing! > >>> To: <bcooks...@kde.org <mailto:bcooks...@kde.org>> > >>> > >>> > >>> *BUILD FAILURE* > >>> Build URL > >>> > https://build.kde.org/job/Administration/job/Dependency%20Build%20Applications%20stable-kf5-qt5%20WindowsMSVCQt5.15/52/ > >>> < > https://build.kde.org/job/Administration/job/Dependency%20Build%20Applications%20stable-kf5-qt5%20WindowsMSVCQt5.15/52/ > > > >>> > >>> Project: Dependency Build Applications stable-kf5-qt5 > >>> WindowsMSVCQt5.15 > >>> Date of build: Fri, 09 Jul 2021 18:58:42 +0000 > >>> Build duration: 22 min and counting > >>> > >>> > >>> *CONSOLE OUTPUT * > >>> [...truncated 51900 lines...] > >>> [2021-07-09T19:20:03.112Z] > >>> > > C:\Craft\CI-Qt515\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qsystemdetection.h(189): > >>> warning C4005: 'Q_OS_WIN': macro redefinition > >>> [2021-07-09T19:20:03.112Z] ..\src\kdeui\kicon.cpp: note: see > >>> previous definition of 'Q_OS_WIN' > >>> [2021-07-09T19:20:03.112Z] [153/533] Building CXX object > >>> src\CMakeFiles\KF5KDELibs4Support.dir\kdeui\kdialogqueue.cpp.obj > >>> [2021-07-09T19:20:03.112Z] > >>> > > C:\Craft\CI-Qt515\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qsystemdetection.h(189): > >>> warning C4005: 'Q_OS_WIN': macro redefinition > >>> [2021-07-09T19:20:03.112Z] ..\src\kdeui\kdialogqueue.cpp: note: > >>> see previous definition of 'Q_OS_WIN' > >>> [2021-07-09T19:20:03.112Z] [154/533] Building CXX object > >>> > src\CMakeFiles\KF5KDELibs4Support.dir\kdecore\ktzfiletimezone.cpp.obj > >>> [2021-07-09T19:20:03.112Z] > >>> > > C:\Craft\CI-Qt515\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qsystemdetection.h(189): > >>> warning C4005: 'Q_OS_WIN': macro redefinition > >>> [2021-07-09T19:20:03.112Z] ..\src\kdecore\ktzfiletimezone.cpp: > >>> note: see previous definition of 'Q_OS_WIN' > >>> [2021-07-09T19:20:03.112Z] [155/533] Building CXX object > >>> src\CMakeFiles\KF5KDELibs4Support.dir\kdeui\kapplication.cpp.obj > >>> [2021-07-09T19:20:03.112Z] > >>> > > C:\Craft\CI-Qt515\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qsystemdetection.h(189): > >>> warning C4005: 'Q_OS_WIN': macro redefinition > >>> [2021-07-09T19:20:03.112Z] ..\src\kdeui\kapplication.cpp: note: > >>> see previous definition of 'Q_OS_WIN' > >>> [2021-07-09T19:20:03.684Z] [156/533] Building CXX object > >>> > src\CMakeFiles\KF5KDELibs4Support.dir\kdeui\kstringvalidator.cpp.obj > >>> [2021-07-09T19:20:03.684Z] > >>> > > C:\Craft\CI-Qt515\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qsystemdetection.h(189): > >>> warning C4005: 'Q_OS_WIN': macro redefinition > >>> [2021-07-09T19:20:03.684Z] ..\src\kdeui\kstringvalidator.cpp: > >>> note: see previous definition of 'Q_OS_WIN' > >>> [2021-07-09T19:20:03.684Z] [157/533] Building CXX object > >>> > src\CMakeFiles\KF5KDELibs4Support.dir\kdeui\kfadewidgeteffect.cpp.obj > >>> [2021-07-09T19:20:03.684Z] > >>> > > C:\Craft\CI-Qt515\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qsystemdetection.h(189): > >>> warning C4005: 'Q_OS_WIN': macro redefinition > >>> [2021-07-09T19:20:03.684Z] ..\src\kdeui\kfadewidgeteffect.cpp: > >>> note: see previous definition of 'Q_OS_WIN' > >>> [2021-07-09T19:20:03.945Z] [158/533] Building CXX object > >>> src\CMakeFiles\KF5KDELibs4Support.dir\kdeui\kbuttongroup.cpp.obj > >>> [2021-07-09T19:20:03.945Z] > >>> > > C:\Craft\CI-Qt515\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qsystemdetection.h(189): > >>> warning C4005: 'Q_OS_WIN': macro redefinition > >>> [2021-07-09T19:20:03.945Z] ..\src\kdeui\kbuttongroup.cpp: note: > >>> see previous definition of 'Q_OS_WIN' > >>> [2021-07-09T19:20:04.205Z] [159/533] Building CXX object > >>> src\CMakeFiles\KF5KDELibs4Support.dir\kdeui\kaction.cpp.obj > >>> [2021-07-09T19:20:04.205Z] > >>> > > C:\Craft\CI-Qt515\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qsystemdetection.h(189): > >>> warning C4005: 'Q_OS_WIN': macro redefinition > >>> [2021-07-09T19:20:04.205Z] ..\src\kdeui\kaction.cpp: note: see > >>> previous definition of 'Q_OS_WIN' > >>> [2021-07-09T19:20:04.205Z] [160/533] Building CXX object > >>> src\CMakeFiles\KF5KDELibs4Support.dir\kdeui\ksessionmanager.cpp.obj > >>> [2021-07-09T19:20:04.205Z] > >>> > > C:\Craft\CI-Qt515\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qsystemdetection.h(189): > >>> warning C4005: 'Q_OS_WIN': macro redefinition > >>> [2021-07-09T19:20:04.205Z] ..\src\kdeui\ksessionmanager.cpp: note: > >>> see previous definition of 'Q_OS_WIN' > >>> [2021-07-09T19:20:04.205Z] [161/533] Building CXX object > >>> src\CMakeFiles\KF5KDELibs4Support.dir\kdeui\kmenu.cpp.obj > >>> [2021-07-09T19:20:04.205Z] > >>> > > C:\Craft\CI-Qt515\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qsystemdetection.h(189): > >>> warning C4005: 'Q_OS_WIN': macro redefinition > >>> [2021-07-09T19:20:04.205Z] ..\src\kdeui\kmenu.cpp: note: see > >>> previous definition of 'Q_OS_WIN' > >>> [2021-07-09T19:20:04.466Z] [162/533] Building CXX object > >>> src\CMakeFiles\KF5KDELibs4Support.dir\kdeui\kdialog.cpp.obj > >>> [2021-07-09T19:20:04.466Z] > >>> > > C:\Craft\CI-Qt515\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qsystemdetection.h(189): > >>> warning C4005: 'Q_OS_WIN': macro redefinition > >>> [2021-07-09T19:20:04.466Z] ..\src\kdeui\kdialog.cpp: note: see > >>> previous definition of 'Q_OS_WIN' > >>> [2021-07-09T19:20:04.466Z] [163/533] Building CXX object > >>> > src\CMakeFiles\KF5KDELibs4Support.dir\kdeui\kcolorvalueselector.cpp.obj > >>> > >>> [2021-07-09T19:20:04.466Z] > >>> > > C:\Craft\CI-Qt515\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qsystemdetection.h(189): > >>> warning C4005: 'Q_OS_WIN': macro redefinition > >>> [2021-07-09T19:20:04.466Z] ..\src\kdeui\kcolorvalueselector.cpp: > >>> note: see previous definition of 'Q_OS_WIN' > >>> [2021-07-09T19:20:04.728Z] [164/533] Building CXX object > >>> src\CMakeFiles\KF5KDELibs4Support.dir\kdeui\karrowbutton.cpp.obj > >>> [2021-07-09T19:20:04.728Z] > >>> > > C:\Craft\CI-Qt515\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qsystemdetection.h(189): > >>> warning C4005: 'Q_OS_WIN': macro redefinition > >>> [2021-07-09T19:20:04.728Z] ..\src\kdeui\karrowbutton.cpp: note: > >>> see previous definition of 'Q_OS_WIN' > >>> [2021-07-09T19:20:04.988Z] [165/533] Building CXX object > >>> src\CMakeFiles\KF5KDELibs4Support.dir\kdecore\klocale.cpp.obj > >>> [2021-07-09T19:20:04.988Z] > >>> > > C:\Craft\CI-Qt515\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qsystemdetection.h(189): > >>> warning C4005: 'Q_OS_WIN': macro redefinition > >>> [2021-07-09T19:20:04.988Z] ..\src\kdecore\klocale.cpp: note: see > >>> previous definition of 'Q_OS_WIN' > >>> [2021-07-09T19:20:04.988Z] [166/533] Building CXX object > >>> src\CMakeFiles\KF5KDELibs4Support.dir\kdeui\kcolordialog.cpp.obj > >>> [2021-07-09T19:20:04.988Z] > >>> > > C:\Craft\CI-Qt515\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qsystemdetection.h(189): > >>> warning C4005: 'Q_OS_WIN': macro redefinition > >>> [2021-07-09T19:20:04.988Z] ..\src\kdeui\kcolordialog.cpp: note: > >>> see previous definition of 'Q_OS_WIN' > >>> [2021-07-09T19:20:05.249Z] [167/533] Building CXX object > >>> src\CMakeFiles\KF5KDELibs4Support.dir\kdeui\kinputdialog.cpp.obj > >>> [2021-07-09T19:20:05.249Z] > >>> > > C:\Craft\CI-Qt515\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qsystemdetection.h(189): > >>> warning C4005: 'Q_OS_WIN': macro redefinition > >>> [2021-07-09T19:20:05.249Z] ..\src\kdeui\kinputdialog.cpp: note: > >>> see previous definition of 'Q_OS_WIN' > >>> [2021-07-09T19:20:05.249Z] [168/533] Building CXX object > >>> src\CMakeFiles\KF5KDELibs4Support.dir\kdeui\kstatusbar.cpp.obj > >>> [2021-07-09T19:20:05.249Z] > >>> > > C:\Craft\CI-Qt515\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qsystemdetection.h(189): > >>> warning C4005: 'Q_OS_WIN': macro redefinition > >>> [2021-07-09T19:20:05.249Z] ..\src\kdeui\kstatusbar.cpp: note: see > >>> previous definition of 'Q_OS_WIN' > >>> [2021-07-09T19:20:05.249Z] [169/533] Building CXX object > >>> src\CMakeFiles\KF5KDELibs4Support.dir\kdeui\ksplashscreen.cpp.obj > >>> [2021-07-09T19:20:05.249Z] > >>> > > C:\Craft\CI-Qt515\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qsystemdetection.h(189): > >>> warning C4005: 'Q_OS_WIN': macro redefinition > >>> [2021-07-09T19:20:05.249Z] ..\src\kdeui\ksplashscreen.cpp: note: > >>> see previous definition of 'Q_OS_WIN' > >>> [2021-07-09T19:20:05.509Z] [170/533] Building CXX object > >>> > src\CMakeFiles\KF5KDELibs4Support.dir\kdeui\khuesaturationselect.cpp.obj > >>> > >>> [2021-07-09T19:20:05.509Z] > >>> > > C:\Craft\CI-Qt515\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qsystemdetection.h(189): > >>> warning C4005: 'Q_OS_WIN': macro redefinition > >>> [2021-07-09T19:20:05.509Z] ..\src\kdeui\khuesaturationselect.cpp: > >>> note: see previous definition of 'Q_OS_WIN' > >>> [2021-07-09T19:20:05.769Z] [171/533] Building CXX object > >>> > src\CMakeFiles\KF5KDELibs4Support.dir\kdeui\kdialogbuttonbox.cpp.obj > >>> [2021-07-09T19:20:05.769Z] > >>> > > C:\Craft\CI-Qt515\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qsystemdetection.h(189): > >>> warning C4005: 'Q_OS_WIN': macro redefinition > >>> [2021-07-09T19:20:05.769Z] ..\src\kdeui\kdialogbuttonbox.cpp: > >>> note: see previous definition of 'Q_OS_WIN' > >>> [2021-07-09T19:20:05.769Z] [172/533] Building CXX object > >>> src\CMakeFiles\KF5KDELibs4Support.dir\kdeui\kshortcut.cpp.obj > >>> [2021-07-09T19:20:05.769Z] > >>> > > C:\Craft\CI-Qt515\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qsystemdetection.h(189): > >>> warning C4005: 'Q_OS_WIN': macro redefinition > >>> [2021-07-09T19:20:05.769Z] ..\src\kdeui\kshortcut.cpp: note: see > >>> previous definition of 'Q_OS_WIN' > >>> [2021-07-09T19:20:06.030Z] [173/533] Building CXX object > >>> > src\CMakeFiles\KF5KDELibs4Support.dir\kdecore\ksystemtimezone.cpp.obj > >>> [2021-07-09T19:20:06.030Z] > >>> > > C:\Craft\CI-Qt515\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qsystemdetection.h(189): > >>> warning C4005: 'Q_OS_WIN': macro redefinition > >>> [2021-07-09T19:20:06.030Z] ..\src\kdecore\ksystemtimezone.cpp: > >>> note: see previous definition of 'Q_OS_WIN' > >>> [2021-07-09T19:20:06.030Z] [174/533] Building CXX object > >>> src\CMakeFiles\KF5KDELibs4Support.dir\kdeui\k4style.cpp.obj > >>> [2021-07-09T19:20:06.030Z] > >>> > > C:\Craft\CI-Qt515\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qsystemdetection.h(189): > >>> warning C4005: 'Q_OS_WIN': macro redefinition > >>> [2021-07-09T19:20:06.030Z] ..\src\kdeui\k4style.cpp: note: see > >>> previous definition of 'Q_OS_WIN' > >>> [2021-07-09T19:20:06.030Z] [175/533] Building CXX object > >>> src\CMakeFiles\KF5KDELibs4Support.dir\kdeui\ktabbar.cpp.obj > >>> [2021-07-09T19:20:06.030Z] > >>> > > C:\Craft\CI-Qt515\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qsystemdetection.h(189): > >>> warning C4005: 'Q_OS_WIN': macro redefinition > >>> [2021-07-09T19:20:06.030Z] ..\src\kdeui\ktabbar.cpp: note: see > >>> previous definition of 'Q_OS_WIN' > >>> [2021-07-09T19:20:06.290Z] [176/533] Building CXX object > >>> src\CMakeFiles\KF5KDELibs4Support.dir\kdeui\ksystemtrayicon.cpp.obj > >>> [2021-07-09T19:20:06.290Z] > >>> > > C:\Craft\CI-Qt515\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qsystemdetection.h(189): > >>> warning C4005: 'Q_OS_WIN': macro redefinition > >>> [2021-07-09T19:20:06.290Z] ..\src\kdeui\ksystemtrayicon.cpp: note: > >>> see previous definition of 'Q_OS_WIN' > >>> [2021-07-09T19:20:06.290Z] [177/533] Building CXX object > >>> src\CMakeFiles\KF5KDELibs4Support.dir\kdeui\knumvalidator.cpp.obj > >>> [2021-07-09T19:20:06.290Z] > >>> > > C:\Craft\CI-Qt515\windows-msvc2019_64-cl-debug\include\qt5\QtCore/qsystemdetection.h(189): > >>> warning C4005: 'Q_OS_WIN': macro redefinition > >>> [2021-07-09T19:20:06.290Z] ..\src\kdeui\knumvalidator.cpp: note: > >>> see previous definition of 'Q_OS_WIN' > >>> [2021-07-09T19:20:06.861Z] [178/533] Linking CXX shared library > >>> bin\KF5KDELibs4Support.dll > >>> [2021-07-09T19:20:06.861Z] FAILED: bin/KF5KDELibs4Support.dll > >>> lib/KF5KDELibs4Support.lib > >>> [2021-07-09T19:20:06.861Z] cmd.exe /C "cd . && > >>> > > C:\Craft\CI-Qt515\windows-msvc2019_64-cl-debug\dev-utils\cmake-base\bin\cmake.exe > >>> -E vs_link_dll --intdir=src\CMakeFiles\KF5KDELibs4Support.dir > >>> --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\rc.exe > >>> --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\mt.exe --manifests > >>> -- > >>> > > C:\PROGRA~2\MICROS~1\2019\PROFES~1\VC\Tools\MSVC\1429~1.300\bin\Hostx64\x64\link.exe > >>> /nologo @CMakeFiles\KF5KDELibs4Support.rsp > >>> /out:bin\KF5KDELibs4Support.dll /implib:lib\KF5KDELibs4Support.lib > >>> /pdb:bin\KF5KDELibs4Support.pdb /dll /version:5.84 /machine:x64 > >>> /debug /INCREMENTAL && cd ." > >>> [2021-07-09T19:20:06.862Z] LINK Pass 1: command > >>> > > "C:\PROGRA~2\MICROS~1\2019\PROFES~1\VC\Tools\MSVC\1429~1.300\bin\Hostx64\x64\link.exe > >>> /nologo @CMakeFiles\KF5KDELibs4Support.rsp > >>> /out:bin\KF5KDELibs4Support.dll /implib:lib\KF5KDELibs4Support.lib > >>> /pdb:bin\KF5KDELibs4Support.pdb /dll /version:5.84 /machine:x64 > >>> /debug /INCREMENTAL /MANIFEST > >>> > /MANIFESTFILE:src\CMakeFiles\KF5KDELibs4Support.dir/intermediate.manifest > >>> src\CMakeFiles\KF5KDELibs4Support.dir/manifest.res" failed (exit > >>> code 1120) with the following output: > >>> [2021-07-09T19:20:06.862Z] Creating library > >>> lib\KF5KDELibs4Support.lib and object lib\KF5KDELibs4Support.exp > >>> [2021-07-09T19:20:06.862Z] k3socketaddress.cpp.obj : error > >>> LNK2019: unresolved external symbol __imp_kde_inet_ntop referenced > >>> in function "public: class QString __cdecl > >>> KNetwork::KIpAddress::toString(void)const " > >>> (?toString@KIpAddress@KNetwork@@QEBA?AVQString@@XZ) > >>> [2021-07-09T19:20:06.862Z] netsupp.cpp.obj : error LNK2001: > >>> unresolved external symbol __imp_kde_inet_ntop > >>> [2021-07-09T19:20:06.862Z] k3socketaddress.cpp.obj : error > >>> LNK2019: unresolved external symbol __imp_kde_inet_pton referenced > >>> in function "public: bool __cdecl > >>> KNetwork::KIpAddress::setAddress(class QString const &)" > >>> (?setAddress@KIpAddress@KNetwork@@QEAA_NAEBVQString@@@Z) > >>> [2021-07-09T19:20:06.862Z] netsupp.cpp.obj : error LNK2001: > >>> unresolved external symbol __imp_kde_inet_pton > >>> [2021-07-09T19:20:06.862Z] bin\KF5KDELibs4Support.dll : fatal > >>> error LNK1120: 2 unresolved externals > >>> [2021-07-09T19:20:06.862Z] ninja: build stopped: subcommand failed. > >>> [Pipeline] } > >>> [Pipeline] // stage > >>> [Pipeline] } > >>> [2021-07-09T19:20:06.892Z] ERROR: script returned exit code 1 > >>> [Pipeline] // catchError > >>> [Pipeline] deleteDir > >>> [Pipeline] bat > >>> [2021-07-09T19:20:45.214Z] > >>> [2021-07-09T19:20:45.214Z] C:\CI\DepBuild>if exist "C:\CI\Software > >>> Installs\Dependencies" rmdir /s /q "C:\CI\Software > >>> Installs\Dependencies" > >>> [Pipeline] emailextrecipients > >>> [Pipeline] emailext > >>> > >>> > >
