dfaure created this revision. dfaure added reviewers: apol, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision.
REVISION SUMMARY This code was disabled in preparation for KF 5.0 to remove kio's dependency on solid. This is ironic because later on kio_trash brought that dependency again. But anyway, this feature was still dead code for all of KF5 life time. The idea of going to /dev and right-click mount/unmount just seems very weird as a GUI feature. (Ignore the comment in the CMakeLists.txt, someone misunderstood what that code was about. No desktop files involved there, this was about block devices themselves) TEST PLAN It builds ;) REPOSITORY R241 KIO BRANCH 2020_04_remove_dead_solid_code REVISION DETAIL https://phabricator.kde.org/D29216 AFFECTED FILES src/widgets/CMakeLists.txt src/widgets/config-kiowidgets.h.cmake src/widgets/kdesktopfileactions.cpp src/widgets/kfileitemactions.cpp To: dfaure, apol, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns