meven requested changes to this revision.
meven added a comment.
This revision now requires changes to proceed.
Nice patch
INLINE COMMENTS
> FileItemLinkingPluginActionLoader.cpp:88
> +
> + {
> auto database = QSqlDatabase::addDatabase(
Do you really need to have block opened here and close line 160 ?
I would favor not adding one as it seems not necessary, (or adapt the
indentation according to the new block)
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D28739
To: akandaurov, ivan, meven
Cc: meven, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov,
iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela,
feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros,
bruns, emmanuelp, rdieter, mikesomov
