iasensio created this revision.
iasensio added reviewers: Plasma, mart, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
iasensio requested review of this revision.

REVISION SUMMARY
  Expose the signal `captureFinished` from the private helper to 
`KeySequenceItem`.
  Currently, if we set `keySequence` from a model and use 
`onKeySequenceChanged` to
  update that model, a binding loop happens. Using `onCaptureFinished` prevents 
that.

TEST PLAN
    keySequence: modelData
    onCaptureFinished: { modelData = keySequence }

REPOSITORY
  R296 KDeclarative

BRANCH
  expose_capture

REVISION DETAIL
  https://phabricator.kde.org/D27795

AFFECTED FILES
  src/qmlcontrols/kquickcontrols/KeySequenceItem.qml

To: iasensio, #plasma, mart, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

Reply via email to