leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision.
REVISION SUMMARY Prior to this patch, without the KDE Platform Dependent, Attica would fail to correctly initialise providers from KNewStuff which were made according to the documentation in KNewStuff when run in systems which did not have Plasma Desktop installed (which is what provides the above mentioned platformdependent). With this patch, while saving and restoring such information doesn't work, at least they will work as intended. This removes the need for including the provider URL in our own released knsrc files, when it is explicitly suggested that it should not be required (it will work just fine for Plasma Desktop provided ones already, as any Plasma install will have the correct plugin, but for any other file, this really should still work the way the documentation says it is supposed to). REPOSITORY R235 Attica BRANCH provide-default-provider-as-per-docs (branched from master) REVISION DETAIL https://phabricator.kde.org/D27123 AFFECTED FILES src/qtplatformdependent.cpp To: leinir Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
