----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115212/#review48120 -----------------------------------------------------------
This review has been submitted with commit 27598328e3a4d046bb35fa328764cf1ec48c3e63 by Alex Richardson to branch master. - Commit Hook On Jan. 22, 2014, 6:01 p.m., Alexander Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115212/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2014, 6:01 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kxmlgui > > > Description > ------- > > 3 separate commits: > > 1. Fix windows build with QT_NO_CAST_FROM_ASCII > > 2. m_collator already returs bool, remove check for < 0 > > 3. Don't use uname() and getpwuid() directly > > Added new functions that also do the right thing on Windows > > > Diffs > ----- > > src/kbugreport.cpp 56f088106becbccca5e9731abc04118a19e36ba9 > src/CMakeLists.txt 4516a9ee3da774788c76f30f15181fa0049a9d86 > src/ksendbugmail/CMakeLists.txt 12b4926ecddeb023315f6074ab57cfe6cdee65ff > src/ksendbugmail/main.cpp 8f85f315f0746bb774175114b1e284e899957fd3 > src/ksendbugmail/smtp.cpp 90b6b98467b0c220cfef18bc35cf3c07df9a8cf3 > src/kshortcutseditoritem.cpp 086f833fc505f69a3b0dbe6fceffdb94ecd60330 > src/systeminformation_p.h PRE-CREATION > src/kkeysequencewidget.cpp cc9016b776c16984b83a36a2742526ede624bf5e > > Diff: https://git.reviewboard.kde.org/r/115212/diff/ > > > Testing > ------- > > now it compiles on windows and Linux is still fine > > > Thanks, > > Alexander Richardson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
