----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112545/#review39690 -----------------------------------------------------------
Looks good to me. About whether it's worth keeping the option: I think that's a question for tsdgeos. But I see no issue in keeping it, you've proven that it's doable :) staging/kdoctools/src/CMakeLists.txt <http://git.reviewboard.kde.org/r/112545/#comment29230> "when " ? staging/kdoctools/src/meinproc.cpp <http://git.reviewboard.kde.org/r/112545/#comment29231> isn't it better to not define the option, so that the user gets "unknown option --cache"? Alternatively, further down, check for isSet("cache") and error out. - David Faure On Sept. 9, 2013, 2:50 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112545/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2013, 2:50 p.m.) > > > Review request for KDE Frameworks and Albert Astals Cid. > > > Description > ------- > > Now we only have the one, which can be compiled without KArchive by ifdef'ing > meinproc.cpp. > > I'm unsure that KArchive it's that big of a dependency, to make it optional. > Opinions? > > > Diffs > ----- > > staging/kdoctools/src/CMakeLists.txt 72bb06e > staging/kdoctools/src/meinproc.cpp 5d476f6 > staging/kdoctools/src/meinproc_simple.cpp 334f13f > > Diff: http://git.reviewboard.kde.org/r/112545/diff/ > > > Testing > ------- > > Builds, both ways. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
