----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111938/#review39049 -----------------------------------------------------------
CMakeLists.txt <http://git.reviewboard.kde.org/r/111938/#comment28794> This is a really strange install dir for plugins. Qt and KF5 install plugins into $LIB_INSTALL_DIR/plugins/. Maybe the correct solution here is LIB_INSTALL_DIR/plugins/qca2 vs LIB_INSTALL_DIR/plugins/qca3? The name "crypto" is just made up by QCA anyway. Well I understand if you don't want to change the qt4 setup (although check git log, I think the support for installing outside the qt prefix is recent, or at least was made default only recently). (also, I'm not sure if there are QCA plugins outside the QCA repo. If not, then we can change the dir any way we want anyway). But at least with qt5 the plugins should be in the same plugin dir as the rest of KF5, so that people don't need to add two different paths to their QT_PLUGIN_PATH. CMakeLists.txt <http://git.reviewboard.kde.org/r/111938/#comment28792> This looks like an unrelated change, better make a separate commit & review for this. tools/qcatool/CMakeLists.txt <http://git.reviewboard.kde.org/r/111938/#comment28793> Maybe remove the "2" from this variable name, for more readability. - David Faure On Aug. 7, 2013, 8:52 p.m., Alexander Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111938/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2013, 8:52 p.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > It is currently not possible to install the -devel packages of qca2 and qca3 > at the same time. > This patch makes sure there are no conflicting files anymore. > > Not sure about what indentation to use, the CMakeLists have both 2 and 4 > spaces... > > > Diffs > ----- > > qca2.pc.cmake 870d46d > tools/qcatool/CMakeLists.txt 50b561f > CMakeLists.txt 3fc6b5f > crypto.prf.cmake a066cf1 > > Diff: http://git.reviewboard.kde.org/r/111938/diff/ > > > Testing > ------- > > Compiled and installed both Qt4 and Qt5 version, only file that conflicts now > is the $PREFIX/lib64/libqca.so symlink > > Maybe it should be renamed to libqca3.so to prevent anyone accidentally > linking to both Qt4 and Qt5, but that may not be necessary. > > > Thanks, > > Alexander Richardson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
