----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111424/#review35677 -----------------------------------------------------------
Ship it! Just missing docu. kdeui/widgets/krichtextwidget.h <http://git.reviewboard.kde.org/r/111424/#comment26164> This needs @since 5.0 and a porting note in KDE5PORTING.html for people who wonder what happened to createActions(KActionCollection *). (this is a case of a disappearing method, so it can't be documented in the api docs for a deprecated method) OK, or you could argue that it's the same method with a signature change, and that people will find it, and then the documentation of how to port (i.e. pointing people to KActionCollection::addActions) can be done in the api docs for this method. As you prefer. - David Faure On July 6, 2013, 6:11 p.m., Andrea Scarpino wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111424/ > ----------------------------------------------------------- > > (Updated July 6, 2013, 6:11 p.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > Move KRichTextWidget and KRichTextEdit to KTextWidgets. > > Needs both https://git.reviewboard.kde.org/r/111210/ and > https://git.reviewboard.kde.org/r/111422/ > > > Diffs > ----- > > kdeui/CMakeLists.txt c7dd8c2 > kdeui/dialogs/klinkdialog.h 1d98548 > kdeui/dialogs/klinkdialog.cpp e83d3e7 > kdeui/tests/CMakeLists.txt b6d5b30 > kdeui/tests/krichtexteditor/CMakeLists.txt 49d4b5d > kdeui/tests/krichtexteditor/krichtexteditor.h 19cde36 > kdeui/tests/krichtexteditor/krichtexteditor.cpp 8e3305c > kdeui/tests/krichtexteditor/krichtexteditorui.rc > kdeui/tests/krichtexteditor/main.cpp c263108 > kdeui/tests/krichtextedittest.h > kdeui/tests/krichtextedittest.cpp 0b91775 > kdeui/widgets/krichtextedit.h 3db647e > kdeui/widgets/krichtextedit.cpp 52b33e2 > kdeui/widgets/krichtextwidget.h 67cb8c9 > kdeui/widgets/krichtextwidget.cpp 7cd3448 > kdeui/widgets/nestedlisthelper.h > kdeui/widgets/nestedlisthelper.cpp 5d2295d > staging/ktextwidgets/autotests/CMakeLists.txt f6d9fd2 > staging/ktextwidgets/src/CMakeLists.txt 6b3c09f > staging/xmlgui/tests/CMakeLists.txt dce637f > > Diff: http://git.reviewboard.kde.org/r/111424/diff/ > > > Testing > ------- > > > Thanks, > > Andrea Scarpino > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
