----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111002/#review34499 -----------------------------------------------------------
Hmmmm very odd, it looks like kviewstatemaintainer.cpp content is almost exactly the same than kviewstatemaintainerbase.cpp content... It's weird that we didn't get problems out of that, there's two identical implementation provided for the same symbol. I think you could let kviewstatemaintainer.cpp go. - Kevin Ottens On June 17, 2013, 1:56 p.m., Wojciech Kapuscinski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111002/ > ----------------------------------------------------------- > > (Updated June 17, 2013, 1:56 p.m.) > > > Review request for KDE Frameworks, David Faure and Kevin Ottens. > > > Description > ------- > > simple move > > Note. > KViewStateSaver is typedef. lxr says that only one class use KViewStateSaver. > Remove this kviewstatesaver.h header? > > > Diffs > ----- > > kdeui/CMakeLists.txt 1dcf6db > kdeui/itemviews/kviewstatemaintainer.h 5ae9797 > kdeui/itemviews/kviewstatemaintainer.cpp cb788ed > kdeui/itemviews/kviewstatesaver.h 4384974 > staging/kconfigwidgets/src/CMakeLists.txt 534b95d > staging/kconfigwidgets/src/kviewstatemaintainer.h PRE-CREATION > staging/kconfigwidgets/src/kviewstatemaintainer.cpp PRE-CREATION > staging/kde4support/src/CMakeLists.txt bb26c4e > staging/kde4support/src/kdeui/kviewstatesaver.h PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/111002/diff/ > > > Testing > ------- > > it builds and tests all OK > > > Thanks, > > Wojciech Kapuscinski > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
