----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110825/ -----------------------------------------------------------
(Updated June 4, 2013, 2:51 p.m.) Review request for KDE Frameworks. Changes ------- Updated the review with d_ed's suggestions. Description ------- Moved KEditListWidget to KWidgetAddons. I changed from KLineEdit to QLineEdit, which I think it's the one that we're supposed to have. Everything worked, but QLineEdit doesn't have setTrapReturnKey. I added code in the event filter to trap the lineedit's return key. Diffs (updated) ----- kdeui/CMakeLists.txt 6e7b7ee kdeui/tests/CMakeLists.txt 6fca0bb kdeui/tests/keditlistwidgettest.cpp ad1a97d kdeui/widgets/keditlistwidget.h dfc16da kdeui/widgets/keditlistwidget.cpp 075bac3 kio/kfile/kurlrequester.h 0b07373 tier1/kwidgetsaddons/src/CMakeLists.txt 9802467 tier1/kwidgetsaddons/tests/CMakeLists.txt bd00be8 Diff: http://git.reviewboard.kde.org/r/110825/diff/ Testing ------- everything builds, the test seems to work Thanks, Aleix Pol Gonzalez
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
