I am having some strange issues with clazy's connect-non-signal and incorrect-emit checks. The only additional insight I can provide beyond what I knew when I made this commit is that compiling kdiff3 in release or release with debug info configuration resolves the warnings.
---------- Forwarded message --------- From: Michael Reeves <n...@kde.org> Date: Fri, Dec 18, 2020, 5:02 PM Subject: [sdk/kdiff3] src: Disable problematic clazy warnings To: <kde-comm...@kde.org> Git commit 4b319434a0a0e9c11f3de358bb307dca75750fb7 by Michael Reeves. Committed on 18/12/2020 at 21:58. Pushed by mreeves into branch 'master'. Disable problematic clazy warnings connect-non-signal and incorrect-emit are generating over one hundred warnings. After performing a quick triage of both clazy and kdiff3 regarding these warnings. I have determined there is no obvious fix and they are false positives. This issue apears with clang/llvm 11 and clazy 1.8. I don't have time to track this down further. Deactiving the offenders until this is resolved. M +2 -0 src/MergeFileInfos.cpp M +1 -0 src/defmac.h M +1 -0 src/difftextwindow.cpp M +1 -0 src/difftextwindow.h M +2 -0 src/directorymergewindow.cpp M +1 -0 src/kdiff3.cpp M +1 -1 src/kdiff3.h M +1 -0 src/kdiff3_shell.cpp M +1 -0 src/mergeresultwindow.cpp M +1 -0 src/pdiff.cpp M +1 -0 src/smalldialogs.cpp https://invent.kde.org/sdk/kdiff3/commit/4b319434a0a0e9c11f3de358bb307dca75750fb7 diff --git a/src/MergeFileInfos.cpp b/src/MergeFileInfos.cpp index a009fa4..3d0ba16 100644 --- a/src/MergeFileInfos.cpp +++ b/src/MergeFileInfos.cpp @@ -5,6 +5,8 @@ * SPDX-FileCopyrightText: 2018-2020 Michael Reeves reeves...@gmail.com * SPDX-License-Identifier: GPL-2.0-or-later */ +//clazy:excludeall=connect-non-signal,incorrect-emit + #include "MergeFileInfos.h" #include "DirectoryInfo.h" diff --git a/src/defmac.h b/src/defmac.h index 6ac4d53..76c03aa 100644 --- a/src/defmac.h +++ b/src/defmac.h @@ -8,6 +8,7 @@ This header is defined macros of general purpose. *****************************************************************************/ +//clazy:excludeall=connect-non-signal,incorrect-emit #ifndef DEFMAC_H #define DEFMAC_H diff --git a/src/difftextwindow.cpp b/src/difftextwindow.cpp index 848cb64..5f18005 100644 --- a/src/difftextwindow.cpp +++ b/src/difftextwindow.cpp @@ -5,6 +5,7 @@ * SPDX-FileCopyrightText: 2018-2020 Michael Reeves reeves...@gmail.com * SPDX-License-Identifier: GPL-2.0-or-later */ +//clazy:excludeall=connect-non-signal,incorrect-emit #include "difftextwindow.h" diff --git a/src/difftextwindow.h b/src/difftextwindow.h index 64bf715..aa89866 100644 --- a/src/difftextwindow.h +++ b/src/difftextwindow.h @@ -5,6 +5,7 @@ * SPDX-FileCopyrightText: 2018-2020 Michael Reeves reeves...@gmail.com * SPDX-License-Identifier: GPL-2.0-or-later */ +//clazy:excludeall=connect-non-signal,incorrect-emit #ifndef DIFFTEXTWINDOW_H #define DIFFTEXTWINDOW_H diff --git a/src/directorymergewindow.cpp b/src/directorymergewindow.cpp index d44b0b5..f2dca29 100644 --- a/src/directorymergewindow.cpp +++ b/src/directorymergewindow.cpp @@ -5,6 +5,8 @@ * SPDX-FileCopyrightText: 2018-2020 Michael Reeves reeves...@gmail.com * SPDX-License-Identifier: GPL-2.0-or-later */ +//clazy:excludeall=connect-non-signal,incorrect-emit + #include "directorymergewindow.h" #include "DirectoryInfo.h" diff --git a/src/kdiff3.cpp b/src/kdiff3.cpp index a3320a6..3d89218 100644 --- a/src/kdiff3.cpp +++ b/src/kdiff3.cpp @@ -5,6 +5,7 @@ * SPDX-FileCopyrightText: 2018-2020 Michael Reeves reeves...@gmail.com * SPDX-License-Identifier: GPL-2.0-or-later */ +//clazy:excludeall=connect-non-signal,incorrect-emit // application specific includes #include "kdiff3.h" diff --git a/src/kdiff3.h b/src/kdiff3.h index 6b671c0..2e3ae09 100644 --- a/src/kdiff3.h +++ b/src/kdiff3.h @@ -5,7 +5,7 @@ * SPDX-FileCopyrightText: 2018-2020 Michael Reeves reeves...@gmail.com * SPDX-License-Identifier: GPL-2.0-or-later */ - +//clazy:excludeall=connect-non-signal,incorrect-emit #ifndef KDIFF3_H #define KDIFF3_H diff --git a/src/kdiff3_shell.cpp b/src/kdiff3_shell.cpp index b6ec641..da67232 100644 --- a/src/kdiff3_shell.cpp +++ b/src/kdiff3_shell.cpp @@ -5,6 +5,7 @@ * SPDX-FileCopyrightText: 2018-2020 Michael Reeves reeves...@gmail.com * SPDX-License-Identifier: GPL-2.0-or-later */ +//clazy:excludeall=connect-non-signal,incorrect-emit #include "kdiff3_shell.h" #include "kdiff3.h" diff --git a/src/mergeresultwindow.cpp b/src/mergeresultwindow.cpp index 5e58fb3..78151fe 100644 --- a/src/mergeresultwindow.cpp +++ b/src/mergeresultwindow.cpp @@ -5,6 +5,7 @@ * SPDX-FileCopyrightText: 2018-2020 Michael Reeves reeves...@gmail.com * SPDX-License-Identifier: GPL-2.0-or-later */ +//clazy:excludeall=connect-non-signal,incorrect-emit #include "mergeresultwindow.h" diff --git a/src/pdiff.cpp b/src/pdiff.cpp index 9670692..e2b2151 100644 --- a/src/pdiff.cpp +++ b/src/pdiff.cpp @@ -5,6 +5,7 @@ * SPDX-FileCopyrightText: 2018-2020 Michael Reeves reeves...@gmail.com * SPDX-License-Identifier: GPL-2.0-or-later */ +//clazy:excludeall=connect-non-signal,incorrect-emit #include "difftextwindow.h" #include "DirectoryInfo.h" diff --git a/src/smalldialogs.cpp b/src/smalldialogs.cpp index 5c12da3..df248a1 100644 --- a/src/smalldialogs.cpp +++ b/src/smalldialogs.cpp @@ -4,6 +4,7 @@ * SPDX-FileCopyrightText: 2002-2011 Joachim Eibl, joachim.eibl at gmx.de * SPDX-License-Identifier: GPL-2.0-or-later */ +//clazy:excludeall=connect-non-signal,incorrect-emit #include "smalldialogs.h"
