Hi Remya,
first, I reordered your email to add new messages at the bottom. See below,
there is my reply.
On 01.11.2018 13:16, Remya Krishnan wrote:
> Hi all,
> First of all, thanks for responding. I unknowingly subscribed for digest
mode but found the
reply in
> public mailing list archive:
https://marc.info/?l=kde-devel&m=154091462602641&w=2
> <https://marc.info/?l=kde-devel&m=154091462602641&w=2>
> I would like to work on https://bugs.kde.org/show_bug.cgi?id=359084.
> <https://bugs.kde.org/show_bug.cgi?id=359084>
> If anyone could give me some guidance to start with, I would appreciate
it. :)
>
> With Regards,
> Remya Krishnan,
> GitHub <https://github.com/krishremya>|FOSS@Amrita
<https://amfoss.in/accounts/165/>
> Amrita University <https://www.amrita.edu/campus/amritapuri>
>
Hi,
you would like to work on this KTurtle-Theme-Bug
(https://bugs.kde.org/show_bug.cgi?id=359084).
I am not into themeing myself but a a good start would be download and
build KTurtle on your
machine, e.g. by following this guide:
https://community.kde.org/Guidelines_and_HOWTOs/Build_from_source
While it is building, you could investigate the source code of the editor
componenent for places
that deal with colors and come back to us with specific questions.
Gregor
On 03.11.2018 18:30, Remya Krishnan wrote:
> Hi all,
>
> Thanks for the pointers. I have the following patch
https://paste.kde.org/pphxfykd4 which fixes bug
> https://bugs.kde.org/show_bug.cgi?id=359084
> I'd like someone to review the same to see if the patch is acceptable. What
should I do next ?
> With Regards,
> Remya Krishnan,
> GitHub <https://github.com/krishremya>|FOSS@Amrita
<https://amfoss.in/accounts/165/>
> Amrita University <https://www.amrita.edu/campus/amritapuri>
>
> On Sat, Nov 3, 2018 at 5:58 PM gregor.mi.sw <codestr...@posteo.org
<mailto:codestr...@posteo.org>>
> wrote:
1. Congratulations! :)
2. Did you check if your code also works with a non-dark theme?
3. Now comes the part that every new contributor has to go through: Sign up for an KDE identity and
get familiar with the Phabricator patch review system. It is all explained here:
https://community.kde.org/Infrastructure/Phabricator
4. Push your patch there and/or come back to us for questions.
Gregor
