On lundi 6 mars 2017 01:29:32 CET Christoph Feck wrote: > On 05.03.2017 23:59, Albert Astals Cid wrote: > > I had a quick look and features seem to work as good/bad in the frameworks > > branch as in master. > > > > If noone disagrees I'll do the merge on March 13th. > > Jeremy Whiting had a list somewhere on todo.kde.org with tasks that > blocked merging. I only remember two, because I was responsible for > them, but I think there were more. > > First, I did not correctly port the saving to remote image via KIO. > Someone familiar with KIO could look at > https://cgit.kde.org/kmag.git/commit/?h=frameworks&id=daa05153573ace5bb76479 > 71a7a21dc724777a4f and correct it.
NetAccess was synchronous, the direct equivalent would be if (!job->exec()) Better would be to connect to the result signal and move the handling of the result to a slot. You probably also want to pass the KIO::Overwrite flag, I think? (otherwise it will fail when the destination already exists) If you want the "rename, overwrite or skip" dialog then use KIO::copy instead of KIO::file_copy. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5
