----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125075/#review84904 -----------------------------------------------------------
Ship it! src/file/extractor/main.cpp (line 42) <https://git.reviewboard.kde.org/r/125075/#comment58741> KAboutData::setApplicationData should be called after application has been created. src/file/powerstatemonitor.h (line 48) <https://git.reviewboard.kde.org/r/125075/#comment58739> I'm not sure if these 'enabled' and 'disabeld' functions are still required. - Vishesh Handa On Sept. 6, 2015, 5:19 p.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125075/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2015, 5:19 p.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > * Split the EventMonitor into 2 classes PowerStateMonitor and > IdleStateMonitor. > * Move delay code to baloo_file_extractor therefore making KF5::IdleTime > dependancy of baloo_file_extractor instead of baloo_file, allowing baloo_file > to drop GUI dependencies. > > > Diffs > ----- > > src/file/fileindexscheduler.cpp b64ff1c > src/file/main.cpp 05cc75f > src/file/powerstatemonitor.h PRE-CREATION > src/file/powerstatemonitor.cpp PRE-CREATION > src/file/extractor/app.cpp 16bb7c0 > src/file/extractor/CMakeLists.txt 13fe7aa > src/file/extractor/idlestatemonitor.h PRE-CREATION > src/file/extractor/idlestatemonitor.cpp PRE-CREATION > src/file/extractor/main.cpp f21ed71 > src/file/filecontentindexer.h 036f8fe > src/file/filecontentindexer.cpp a9ba4bc > src/file/fileindexscheduler.h 78b5b56 > src/file/extractor/app.h 85da1ec > src/file/eventmonitor.cpp d245ad7 > src/file/CMakeLists.txt 1caf7c3 > src/file/eventmonitor.h 4375bd2 > > Diff: https://git.reviewboard.kde.org/r/125075/diff/ > > > Testing > ------- > > baloo seems to be working fine. > > > Thanks, > > Pinak Ahuja > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
