----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124443/#review83092 -----------------------------------------------------------
Ship it! Awesome. Good work. - Vishesh Handa On July 27, 2015, 3:16 p.m., Dāvis Mosāns wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124443/ > ----------------------------------------------------------- > > (Updated July 27, 2015, 3:16 p.m.) > > > Review request for Baloo. > > > Repository: baloo > > > Description > ------- > > When file's data extractor fails or skips for whatever reason then doc.m_data > will be empty > causing assert so just skip it. > > ASSERT: "!url.isEmpty()" in file > /mnt/KDE/kde/workspace/baloo/src/engine/documentdatadb.cpp, line 60 > > > Diffs > ----- > > src/engine/writetransaction.cpp a5936b8cbfdd64ddc10b24f283358aca308c1131 > > Diff: https://git.reviewboard.kde.org/r/124443/diff/ > > > Testing > ------- > > Doesn't cause assert anymore. > > > Thanks, > > Dāvis Mosāns > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
