----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123712/#review80154 -----------------------------------------------------------
John, this is great. However you'll need to split it up into 2 different patches and therefore 2 different review requests. It'll be a good experiment of your git skills, and you'll learn more about reviewboard. src/file/basicindexingjob.cpp (line 156) <https://git.reviewboard.kde.org/r/123712/#comment55003> Just do - static QMultiHash<QString, Type::Type> = { ... }; - Vishesh Handa On May 10, 2015, 3:52 a.m., John Freeman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123712/ > ----------------------------------------------------------- > > (Updated May 10, 2015, 3:52 a.m.) > > > Review request for Baloo. > > > Repository: baloo > > > Description > ------- > > BasicIndexingJob::typesForMimeType no longer checks typeMapper.isEmpty() > instead is initialized once with an initializer_list > > > Diffs > ----- > > src/file/basicindexingjob.cpp fc7211a > > Diff: https://git.reviewboard.kde.org/r/123712/diff/ > > > Testing > ------- > > > Thanks, > > John Freeman > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
