----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120188/#review66520 -----------------------------------------------------------
Ship it! Looks amazing! Please commit it under the master branch. Have a look at how the other commit messages are structured (git log). It's typically one sentence on the first line, second line blank, and from the third line a longer message if required. src/file/autotest/basicindexingjobtest.cpp <https://git.reviewboard.kde.org/r/120188/#comment46366> This header can also be removed. - Vishesh Handa On Sept. 13, 2014, 7:14 p.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120188/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2014, 7:14 p.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > Move sqlite stuff from BasicIndexingJob to BasicIndexingQueue > > > Diffs > ----- > > src/file/autotest/basicindexingjobtest.cpp 0135322 > src/file/basicindexingjob.h f9f7842 > src/file/basicindexingjob.cpp 3352014 > src/file/basicindexingqueue.h 4bbfaa1 > src/file/basicindexingqueue.cpp 9077a93 > src/file/extractor/app.cpp 0ff9a24 > > Diff: https://git.reviewboard.kde.org/r/120188/diff/ > > > Testing > ------- > > > Thanks, > > Pinak Ahuja > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
