----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118448/#review64111 -----------------------------------------------------------
Both Vishesh and me are at Randa, let's get this reviewed and decided this week. src/queryparser/pass_periodnames.cpp <https://git.reviewboard.kde.org/r/118448/#comment44753> This leaks, should delete cal - Albert Astals Cid On jun. 13, 2014, 11:02 a.m., Denis Steckelmacher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118448/ > ----------------------------------------------------------- > > (Updated jun. 13, 2014, 11:02 a.m.) > > > Review request for Baloo, Localization and Translation (l10n) and Alexander > Potashev. > > > Repository: baloo > > > Description > ------- > > The query parser made the erroneous assumption that each language uses at > most one calendar system, and therefore used i18nc to translate the month and > day names recognized by the parser. This patches changes that and uses the > KCalendarSystem of the user to get the month and day names. > > I've written the code by looking at how the gregorian, hebrew and islamic > calendars work (these are the three that I somehow understand). The idea is > to try to get as many days and months as possible, by incrementing an index > until the calendar system returns NULL strings. This works well for days, but > monthName() requires a year, that is used by some calendar systems to > rename/add months on leap years. I pass the current year, as most of the > users will look for dates not too far in the future nor in the past. Is there > a mean to get the complete list of month names and their corresponding > number, using KCalendarSystem or anything else? > > > Diffs > ----- > > src/queryparser/pass_periodnames.h 1d7d522 > src/queryparser/pass_periodnames.cpp da688ed > > Diff: https://git.reviewboard.kde.org/r/118448/diff/ > > > Testing > ------- > > The query parser testsuite still passes, and properly gets the name of > Gregorian months and days (the tests run using the C locale). > > > Thanks, > > Denis Steckelmacher > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
