----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117902/#review57313 -----------------------------------------------------------
Ship it! Sorry, I didn't notice. - Vishesh Handa On April 30, 2014, 2:03 p.m., Alexander Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117902/ > ----------------------------------------------------------- > > (Updated April 30, 2014, 2:03 p.m.) > > > Review request for Baloo. > > > Repository: baloo > > > Description > ------- > > Use PUBLIC and PRIVATE in target_link_libraries for the installed libs > > > Diffs > ----- > > src/core/CMakeLists.txt f9f663b1c1ba4c84057e76da09903c7a7c53da45 > src/file/CMakeLists.txt 79a22551f0a8fa7475b69930c381057b42ca10fb > src/file/autotest/CMakeLists.txt a476a8d273bf9674221868f1cf287cd100191c76 > src/file/extractor/CMakeLists.txt d8abe98c23b95440e0320b158f44cdca6428e7a6 > src/file/lib/CMakeLists.txt a432ebb17ba6b66065ade31240217020b2df2ba4 > src/file/lib/autotests/CMakeLists.txt > 9676c2e01c980ddb36c18a44ac1d8d08f862d1ea > src/file/tests/CMakeLists.txt f8386ae735e3bbc24f51402e59d5fc701afddd8d > src/pim/lib/CMakeLists.txt b57340872800ead1fcd224235b2f7b6f3f8ad172 > src/xapian/CMakeLists.txt 38a4b2ed08db52cc8e2bc1e09ad3290bb6122515 > > Diff: https://git.reviewboard.kde.org/r/117902/diff/ > > > Testing > ------- > > No longer need to find the private dependencies when building dolphin > (frameworks) > > > Thanks, > > Alexander Richardson > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<