----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116919/#review53500 -----------------------------------------------------------
It's a good start :) This can however can be improved quite a bit. Lets get rid of the UpdateRequest class altogether. It no longer serves any purpose. Please also run the metadatamover test. Your patch makes it fail. src/file/metadatamover.cpp <https://git.reviewboard.kde.org/r/116919/#comment37605> This code path can now never run since there is an assert check to make sure to is never empty. It would be best for you to only call removeMetadata(to) and updateMetadata(from, to) src/file/metadatamover.cpp <https://git.reviewboard.kde.org/r/116919/#comment37607> Since this function is for removing the file Metadata, the second code path for updating is no longer required. Please remove it. src/file/metadatamover.cpp <https://git.reviewboard.kde.org/r/116919/#comment37606> Please remove the comment - Vishesh Handa On March 20, 2014, 10:10 a.m., Nitul Datt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116919/ > ----------------------------------------------------------- > > (Updated March 20, 2014, 10:10 a.m.) > > > Review request for Baloo and Vishesh Handa. > > > Bugs: 329039 and bug > http://bugs.kde.org/show_bug.cgi?id=329039 > http://bugs.kde.org/show_bug.cgi?id=bug > > > Repository: baloo > > > Description > ------- > > Removed the internal queue from metadatamover. Now, events are processed as > they arrive. > > > Diffs > ----- > > src/file/metadatamover.h d7975ec > src/file/metadatamover.cpp 14d454a > > Diff: https://git.reviewboard.kde.org/r/116919/diff/ > > > Testing > ------- > > > Thanks, > > Nitul Datt > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
