> On March 5, 2014, 11:53 a.m., David Edmundson wrote: > > ConfigureChecks.cmake, line 1 > > <https://git.reviewboard.kde.org/r/115877/diff/1/?file=244871#file244871line1> > > > > Why rename this from FindXattr.cmake? > > > > it's basically doing the same thing, but searching in more places? > > > > Downside to your approach is it means it's impossible to manually set > > xattr path with ccmake
These headers are libc/OS-provided ones and thus I think having a FindXattr.cmake makes as much sense as replacing the checks in kdelibs' ConfigureChecks.cmake with Find-files doing the same thing. - Raphael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115877/#review52046 ----------------------------------------------------------- On Feb. 19, 2014, 12:48 a.m., Raphael Kubo da Costa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115877/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2014, 12:48 a.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > This is patch 1/2 of making the extended attributes support work on > non-Linux operating systems, and covers the build-system changes. > > Replace the Linux-specific FindXAttr.cmake with a more standard > ConfigureChecks.cmake that looks for extended attributes-related headers in > multiple locations to account for multiple operating system implementations. > > > Diffs > ----- > > cmake/modules/FindXattr.cmake 530eb6ddba45149fe86e04ca6c5154471a2e0272 > CMakeLists.txt d9be10f5b5f89205ab09a81ed0afc016238d5b7d > ConfigureChecks.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/115877/diff/ > > > Testing > ------- > > I stop getting fatal errors on FreeBSD due to the Linux xattr headers not > being found. > > > Thanks, > > Raphael Kubo da Costa > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
