----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115267/#review48150 -----------------------------------------------------------
Ship it! Nice! Feel free to push it once you've fixed the coding style changes. src/core/searchstore.h <https://git.reviewboard.kde.org/r/115267/#comment34055> Coding style. Please remove the space around the paranthesis. Also, "org.kde.Baloo" perhaps? src/core/searchstore.cpp <https://git.reviewboard.kde.org/r/115267/#comment34059> I'm sorry about, but I've been using Type* instead of Type *. Would you mind changing to Type* instead. It'll be more consistent. src/core/searchstore.cpp <https://git.reviewboard.kde.org/r/115267/#comment34060> Could you also please add a space after the // src/core/searchstore.cpp <https://git.reviewboard.kde.org/r/115267/#comment34061> Coding Style: Please move else to the next line - Vishesh Handa On Jan. 23, 2014, 5:02 p.m., Christian Mollekopf wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115267/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2014, 5:02 p.m.) > > > Review request for Baloo. > > > Repository: baloo > > > Description > ------- > > SearchStore: Switch to QPluginLoader based plugins. > > KPluginFactory calls KGlobal::locale() which crashes if it wasn't initialized > from the main thread of the program. In the case of akonadi (since akonadi is > a qt application), we can't initialize it, therefore we avoid it altoghether. > > > Diffs > ----- > > src/core/searchstore.h c2363cc > src/core/searchstore.cpp 1a41e27 > src/file/search/autotest/filesearchstoretest.cpp a01ef1d > src/file/search/filesearchstore.h bcdd1cd > src/file/search/filesearchstore.cpp f2a2ae4 > src/pim/search/contact/contactsearchstore.h 9406e3b > src/pim/search/contact/contactsearchstore.cpp c7a4e11 > src/pim/search/email/emailsearchstore.h 61f299c > src/pim/search/email/emailsearchstore.cpp 83f452c > > Diff: https://git.reviewboard.kde.org/r/115267/diff/ > > > Testing > ------- > > > Thanks, > > Christian Mollekopf > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
