Hi,
I have fixed the following:
- removed Author, Email, Bug_Address from top CMakeLists.txt
- set destination to use ${SYSCONF_INSTALL_DIR}
- use ecm_install_icons from ecm to install the icons
- in plugin/CMakeLists.txt removed unused pkgconfig
- added a ATTRIBUTION file to top directory to mark usage of images (wikipedia
icon)
- added a Copying.apache2 license file as MSM.sh, Mycroft are now Apache 2.0
licensed
- added license headers to all files in plasmoid/content/ui missing the header
- removed .directory file in plasmoid/contents/images
I am not sure about the COPYING file as I think this should be under GPL-2.1 as
most other plasmoid/applets also seemed to be released under this license does
this file need to be updated to reflect 2.1 specifically ?
Regards,
Aditya Mehra
________________________________
From: kde-core-devel <kde-core-devel-boun...@kde.org> on behalf of Christophe
Giboudeaux <christo...@krop.fr>
Sent: Friday, December 15, 2017 1:40 AM
To: kde-core-devel@kde.org
Subject: Re: Plasma-Mycroft is in kdereview
Hi,
On mardi 5 décembre 2017 08:52:18 CET Aditya Mehra wrote:
> Hi all,
>
> This is a request email for the review process of the mycroft plasmoid, the
> plasma-mycroft project has been moved to kdereview
>
> The repository url: https://cgit.kde.org/plasma-mycroft.git/
>
Just commenting on the build system part.
In the top CMakeLists.txt :
- AUTHOR, EMAIL, BUG_ADDRESS are set but not used anywhere, just remove them.
- install( DIRECTORY mycroft DESTINATION /etc ) → use ${SYSCONF_INSTALL_DIR}
instead of /etc
- Instead of using install( DIRECTORY ...), please use ecm_install_icons from
ECM.
- in plugin/CMakeLists.txt, you include pkgconfig but don't use it for
anything
other notes :
- COPYING contains the GPL-2.0 license but nothing needs it
- msm.sh is GPL-3.0+ but there's no license file in the repository
- There's a wikipedia icon in the repo, don't forget the terms (the
attribution part) : https://creativecommons.org/licenses/by-sa/3.0/
- some files in plasmoid/content/ui don't have a license header
- there's a .directory file in plasmoid/contents/images, this should probably
not be in the repo :)
That's all.
