> On Nov. 5, 2016, 10:39 a.m., Andreas Sturmlechner wrote: > > kwalletd/CMakeLists.txt, line 8 > > <https://git.reviewboard.kde.org/r/129339/diff/1/?file=484099#file484099line8> > > > > Please do this in reverse logic, same as in the kwallet.git commit you > > are referring to - that means searching for Gpgmepp first (which is unique > > to GpgME++) and only if NOT Gpgmepp_FOUND do you search for Gpgme and > > QGpgme (the latter is both known to kdepimlibs-4 and GpgME++) to make sure > > there is no bogus linking and to avoid confusion in FEATURE_SUMMARY output.
That would make it use gmgpe 1.7 by default if it is installed. Is such a behavior change acceptable in a package that is essentially in maintenance mode? Also, cmake would throw "gpgme not found" errors even if the kdepimlibs version is installed, which could be confusing. Note that QGPGME_FOUND is not satisfied by qgpgme from gpgme (at least in 1.7.1), so I see no chance of confusion. - Antonio ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129339/#review100593 ----------------------------------------------------------- On Nov. 5, 2016, 9:35 a.m., Antonio Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129339/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2016, 9:35 a.m.) > > > Review request for KDE Runtime and Andreas Sturmlechner. > > > Repository: kde-runtime > > > Description > ------- > > This patch, based on the one from the kwallet repo, allows building kwalletd > against the gpgme++ library provided by gpgme 1.7 instead of the kdepimlibs > one. > > > Diffs > ----- > > kwalletd/CMakeLists.txt 73aec82 > kwalletd/backend/CMakeLists.txt 4db348f > kwalletd/backend/backendpersisthandler.cpp b7f63f8 > kwalletd/kwalletwizard.cpp 78de78d > > Diff: https://git.reviewboard.kde.org/r/129339/diff/ > > > Testing > ------- > > Built: > 1) with kdepimlibs > 2) with no kdepimlibs and gpgme 1.7 > 3) with no kdepimlibs and no gpgme > > Builds correctly in all cases, links to the expected version of libgpgme++ in > the first two cases. In the first case there is no change in behaviour with > respect to the previous situation. > > > Thanks, > > Antonio Rojas > >
