----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128305/#review96940 -----------------------------------------------------------
Ship it! Ship It! - Sebastian Kügler On June 28, 2016, 4:09 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128305/ > ----------------------------------------------------------- > > (Updated June 28, 2016, 4:09 p.m.) > > > Review request for KDE Base Apps. > > > Repository: kde-baseapps > > > Description > ------- > > This has the file manager open the parent folder(s), scroll to and highlight > the file(s). > > > Diffs > ----- > > CMakeLists.txt c10342f > kfind/kfindtreeview.cpp e546b6e > > Diff: https://git.reviewboard.kde.org/r/128305/diff/ > > > Testing > ------- > > Needs Review 128306 to fully work. > > While the specs says "The behavior for more than one element is left up to > the implementation.", at least Dolphin is smart enough to highlight multiple > files within the same folder and even opens separate tabs for different > parent folders, essentially re-creating the logic we previously had here, > except that it'll result in just one file manager window now. > > > Thanks, > > Kai Uwe Broulik > >
