----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125995/#review88169 -----------------------------------------------------------
Ship it! Ship It! - David Faure On Nov. 8, 2015, 6:45 p.m., Frank Reininghaus wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125995/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2015, 6:45 p.m.) > > > Review request for KDE Base Apps and David Faure. > > > Repository: kde-baseapps > > > Description > ------- > > KIO installs this file since version 5.16. > > Even if the frameworks branch of lib/konq is currently unreleased, resolving > this file installation conflict makes life easier for those who package it > (reported in https://bugs.kde.org/show_bug.cgi?id=353642#c12 ) > > > Diffs > ----- > > lib/konq/src/CMakeLists.txt b2d0c7e > > Diff: https://git.reviewboard.kde.org/r/125995/diff/ > > > Testing > ------- > > kde-baseapps does not try to install the file any more. If I artificially > increase the checked version to 5.17, it does try, so I'm confident that this > will work fine with KIO versions prior to 5.16 and install the file (which is > needed to make the context menu for files work properly in Dolphin, > FolderView, Konqueror, etc.). > > > Thanks, > > Frank Reininghaus > >
