----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125910/#review87941 -----------------------------------------------------------
Looks good to me kdeui/notifications/knotificationrestrictions.cpp (lines 48 - 50) <https://git.reviewboard.kde.org/r/125910/#comment60329> Btw. the commas are put in the beginning of the lines to have an easy way to comment that particular line; you can just comment the whole line and don't have to worry about the comma at the end of the previous line. This is not an issue, I'm just explaining why it was at the beginning of the line (or why I think it was) :) - Martin Klapetek On Nov. 1, 2015, 10:50 p.m., Johannes Stefan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125910/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2015, 10:50 p.m.) > > > Review request for kdelibs and Martin Klapetek. > > > Bugs: 334525 > http://bugs.kde.org/show_bug.cgi?id=334525 > > > Repository: kdelibs > > > Description > ------- > > Setting default reason for going into fullscreen mode > > > Diffs > ----- > > kdeui/notifications/knotificationrestrictions.cpp 818edea > > Diff: https://git.reviewboard.kde.org/r/125910/diff/ > > > Testing > ------- > > Compiled an tested - DBus Log as expected: > > ##### begin DBUS-log ##### > method call sender=:1.223 -> dest=org.freedesktop.ScreenSaver serial=56 > path=/ScreenSaver; interface=org.freedesktop.ScreenSaver; member=Inhibit > string "Gwenview" > string "no_reason_specified" > method call sender=:1.6 -> dest=:1.3 serial=588 > path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; > member=Inhibit > string "Gwenview" > uint32 0 > string "no_reason_specified" > uint32 8 > signal sender=:1.3 -> dest=(null destination) serial=351 > path=/org/gnome/SessionManager; interface=org.freedesktop.DBus.Properties; > member=PropertiesChanged > string "org.gnome.SessionManager" > array [ > dict entry( > string "InhibitedActions" > variant uint32 8 > ) > ] > array [ > ] > signal sender=:1.3 -> dest=(null destination) serial=352 > path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; > member=InhibitorAdded > object path "/org/gnome/SessionManager/Inhibitor29" > method return sender=:1.3 -> dest=:1.6 reply_serial=588 > uint32 1169992534 > method call sender=:1.4 -> dest=:1.21 serial=56 > path=/org/gnome/Mutter/IdleMonitor/Core; > interface=org.gnome.Mutter.IdleMonitor; member=RemoveWatch > uint32 35 > method call sender=:1.6 -> dest=org.freedesktop.DBus serial=589 > path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=AddMatch > string > "type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0=':1.223'" > method call sender=:1.6 -> dest=org.freedesktop.DBus serial=590 > path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; > member=GetNameOwner > string ":1.223" > method return sender=:1.6 -> dest=:1.223 reply_serial=56 > uint32 1169992534 > method call sender=:1.6 -> dest=:1.21 serial=592 > path=/org/gnome/Mutter/DisplayConfig; > interface=org.freedesktop.DBus.Properties; member=Set > string "org.gnome.Mutter.DisplayConfig" > string "PowerSaveMode" > variant int32 0 > method call sender=:1.21 -> dest=:1.3 serial=1073 > path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; > member=IsInhibited > uint32 16 > method call sender=:1.21 -> dest=org.freedesktop.DBus serial=1074 > path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=RemoveMatch > string > "type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0=':1.4'" > method return sender=:1.21 -> dest=:1.4 reply_serial=56 > method return sender=:1.3 -> dest=:1.21 reply_serial=1073 > boolean false > ##### end of DBUS-log ##### > > > Thanks, > > Johannes Stefan > >
