----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125582/#review86621 -----------------------------------------------------------
Ship it! Looks good. I just wonder whether any toolchain on Windows needs the non-underscore timezone variable. - Harri Porten On Oct. 10, 2015, 12:03 p.m., Gleb Popov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125582/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2015, 12:03 p.m.) > > > Review request for kdelibs and Harri Porten. > > > Repository: kjs > > > Description > ------- > > Use "_timezone" global variable for MSVC instead of "timezone". Fixes build > with MSVC 2015. > > > Diffs > ----- > > src/kjs/date_object.cpp add2cea > > Diff: https://git.reviewboard.kde.org/r/125582/diff/ > > > Testing > ------- > > > Thanks, > > Gleb Popov > >
