----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124657/#review83584 -----------------------------------------------------------
Ship it! Ship It! - David Faure On Aug. 8, 2015, 2:24 p.m., Luigi Toscano wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124657/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2015, 2:24 p.m.) > > > Review request for KDE Base Apps and David Faure. > > > Repository: kde-baseapps > > > Description > ------- > > Fix two KUrl porting TODO items. Thanks to the porting notes! > The URL of the bookmark was not shown because the value was not > passed to the treeview/table model and to the textbox. > > > Diffs > ----- > > keditbookmarks/bookmarkinfowidget.cpp 98ce303 > keditbookmarks/kbookmarkmodel/model.cpp e949469 > > Diff: https://git.reviewboard.kde.org/r/124657/diff/ > > > Testing > ------- > > Compiled, executed the bookmark editor. Added and changed few bookmarks, the > URL is correctly updated. > > > Thanks, > > Luigi Toscano > >