On 4 July 2015 at 05:30, Alexander Potashev <aspotas...@gmail.com> wrote: > 2015-07-04 0:53 GMT+03:00 Albert Astals Cid <aa...@kde.org>: >> For some reason /usr/include/x86_64-linux-gnu/qt5/QtX11Extras is not in the >> include path. >> >> Any idea why? > > Fixed in > http://commits.kde.org/kscreengenie/ace898e614d612a84ee12f22562d6d7365ee24bc > > Because when XCB_FOUND is not set, Qt5::X11Extras is not added to > target_link_libraries(), see src/CMakeLists.txt. > target_link_libraries() implicitly also adds respective include > directories. When there is no target_link_libraries(... > Qt5::X11Extras), [...]/QtX11Extras is not added as include path.
You've gone ahead and moved all the includes from the header file to the .cpp file? I'm going to revert that commit, since the decision to keep all the #includes in the header is a coding style decision I consciously made. I know this extends build times, but this keeps things tidy - I can see exactly which components a single cpp file depends on my looking at the headers, I don't have to look through both the cpp and the header file. The cpp file should include one and only one header file, and that's it's own header. I appreciate you fixing the build without XCB very much. However, before making major coding style changes, please use the Review Board or ask over e-mail. KScreenGenie does *not* use the kdelibs coding style.
