----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122404/#review75306 -----------------------------------------------------------
I really think this code needs to be in phononserver or better yet Phonon itself (akin to the pulsesupport) or even better in VLC. The solid audiointerface stuff is gone in frameworks5, so ultimately this is a dead end. Equally phononserver is bound to go away at some point in the future and being replaced by listing exclusively what phonon reports (which in turn is pulseaudio listing || backend listing). So, enabling VLC to expose this information through the libvlc_audio_output_device enumerable would be the best course of action. If the VLC devs don't want that or whatever, then putting it in Phonon seems the most useful approach. - Harald Sitter On Feb. 3, 2015, 12:44 p.m., René J.V. Bertin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122404/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2015, 12:44 p.m.) > > > Review request for KDE Software on Mac OS X, kdelibs, Phonon, and Solid. > > > Repository: kdelibs > > > Description > ------- > > While trying to bring a functional Multimedia kcm to OS X (see > https://git.reviewboard.kde.org/r/122403/), I realised that Solid's IOKit > backend doesn't currently support audio devices. > > This RR outlines the current state of my draft attempt to provide that > support. I'm handicapped by my lack of experience with both IOKit and Solid, > and would thus appreciate a helping hand. > > I'm currently at a stage where Solid returns a list representing the audio > devices present in my system, but apparently not with the correct metadata > for phononserver to consider them, despite the fact that I pretend all > devices to be pluripotent (i.e. AUDIOCONTROL|AUDIOINPUT|AUDIOOUTPUT) : > > ``` > kded(81671)/phonon (kded module) PhononServer::findDevices: Solid offers 5 > audio devices > kded(81671)/phonon (kded module) PhononServer::findDevices: Solid offers 0 > video devices > ... > kded(81671)/phonon (kded module) PhononServer::findDevices: groups: () > kded(81671)/phonon (kded module) PhononServer::findDevices: already found > devices: QSet() > kded(81671)/phonon (kded module) PhononServer::findDevices: Audio Playback > Devices: () > kded(81671)/phonon (kded module) PhononServer::findDevices: Audio Capture > Devices: () > kded(81671)/phonon (kded module) PhononServer::findDevices: Video Capture > Devices: () > kded(81671)/kded4 *Kded::loadModule: Successfully loaded module "phononserver" > ``` > > I'll add a more complete log as an attachment. > > > Diffs > ----- > > solid/solid/CMakeLists.txt a7f1f07 > solid/solid/backends/iokit/iokitdevice.cpp f113c16 > solid/solid/backends/iokit/iokitmanager.cpp fcd748e > solid/solid/devicemanager.cpp a465169 > > Diff: https://git.reviewboard.kde.org/r/122404/diff/ > > > Testing > ------- > > On OS X 10.9.5/MacPorts with kdelibs 4.14.4 (git/master), kde4-runtime > (git/master) and kde4-workspace (git/master); phonon 4.8.3 with > phonon-backend-gstreamer 4.8.2 . > > > File Attachments > ---------------- > > full trace with debug output > > https://git.reviewboard.kde.org/media/uploaded/files/2015/02/03/67a59590-84a4-4d30-88aa-332d9f068a2c__Solid-20150203.log > > > Thanks, > > René J.V. Bertin > >
