----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122320/#review75061 -----------------------------------------------------------
startkde/kcminit/main.cpp <https://git.reviewboard.kde.org/r/122320/#comment51954> .. || xcb_connection_has_error(c) where did you obtain that code? (the check is insufficient, there should usually always be a non-null return) - Thomas Lübking On Jan. 29, 2015, 11:24 nachm., Nick Shaforostoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122320/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2015, 11:24 nachm.) > > > Review request for kde-workspace, Martin Gräßlin and Thomas Lübking. > > > Repository: plasma-workspace > > > Description > ------- > > this patch makes kcminit behave like in kde4: it uses proper xcb screen count > which may be different from QGuiApplication::screens().count(). > > for example when i connext external monitor via vga to my laptop, xcb screen > count is still '1', while QGuiApplication::screens().count() returns '2'. > > switching from QGuiApplication to QCoreApplication still wasn't possible > because modules like 'mouse' need gui initialized and would crash if kcminit > uses QCoreApplication. > > > Diffs > ----- > > startkde/kcminit/CMakeLists.txt b17951f > startkde/kcminit/main.cpp 1008966 > > Diff: https://git.reviewboard.kde.org/r/122320/diff/ > > > Testing > ------- > > i have built kcminit on ubuntu vivid alpha 32-bit, replaced binaries and > libraries in the system and successfuly could run kcminit_startup and reboot > also went fine. > > > Thanks, > > Nick Shaforostoff > >
