----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122270/#review74973 -----------------------------------------------------------
I still think this is wrong as QGuiApplication::screens().count() gives the count of the xrandr screens and not of X11 screens. startkde/kcminit/main.cpp <https://git.reviewboard.kde.org/r/122270/#comment51927> nitpick coding style: whitespaces around the == and the { goes together tisth the if() startkde/kcminit/main.cpp <https://git.reviewboard.kde.org/r/122270/#comment51928> drop the else case and move the variable definition outside the ifdef block? - Martin Gräßlin On Jan. 29, 2015, 2:19 a.m., Nick Shaforostoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122270/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2015, 2:19 a.m.) > > > Review request for kde-workspace, Aleix Pol Gonzalez, Martin Gräßlin, and > Lukáš Tinkl. > > > Repository: plasma-workspace > > > Description > ------- > > Now kcminit is linked with less libraries -> startup time improved > > I also suggest always setting KDE_MULTIHEAD=true to eliminate ini file access > during startup and to be able to stop linking against QtGui > > > Diffs > ----- > > startkde/kcminit/CMakeLists.txt ffae38c > startkde/kcminit/main.h 1140b77 > startkde/kcminit/main.cpp 4724323 > > Diff: https://git.reviewboard.kde.org/r/122270/diff/ > > > Testing > ------- > > compiled, ran 'kcminit --list' and kcminit AAA > > > Thanks, > > Nick Shaforostoff > >
