decoration.h
-------------
borderLeft|Right|Bottom|Top
Use QMargins here as well (they'll usually be required together)?

extendedBorder*
QMargins as well?. Also maybe "resizeOnlyBorder"? (extendedBorder is very 
generic)

"titleRect"
is this "titleBarRect" or "captionRect" - and should the name be more specific?
(And if it points an entire section to allow vertical titles etc. would a 
Qt::WindowFrameSection make more sense?)

"setSettings"
As this is supposed to be only invoked from the framework, make private to a 
friend class/function?

"paint"
w/o having looked at the paint system, but assuming it operates on translation and 
clip"region"(rect), maybe explicitly hand the rect for this pass to be painted 
as paramenter?

"requestMaximize"
rename to "requestToggleMaximize|ization"?

"windowFrameSection":
What's that supposed to be at all? "Decoration" will not point a single tile of 
the Decoration, does it?

Cheers,
Thomas

Reply via email to