On Tue, Dec 10, 2013 at 1:45 PM, Albert Astals Cid <aa...@kde.org> wrote:
> El Dimarts, 10 de desembre de 2013, a les 08:57:47, Dawit A va escriure: > > Sorry for the late response. I did not see this email for some reason. > None > > of the test cases in testRetryDialog hit that assert on my machine. > > Is your Qt compiled in debug or release? Because as my original e-mail > says if > it's in release the assert won't trigger. > Ahh... I assumed you were talking about kde-runtime not Qt. > > > If this > > unit test fails on your system, can you please enable the debug area for > > KPasswdServer, run the unit test only for testRetryDialog only and > provide > > the output from it? > > Attached, is that enough? > That is fine. The test is indeed doing the wrong thing. It conflated two cases that should be tested separately into one. > > > I am curious to know why it would start failing all of > > the sudden since nothing was changed in that code base in a very long > time. > > Because we switched to a debug Qt that now has asserts enabled. > Right. Can you please check if the attached pass works fine for you? It fixes the broken test case for me here.
kpasswdservertest.patch
Description: Binary data
