> On Nov. 20, 2013, 12:21 p.m., Fredrik Höglund wrote: > > tier1/kwindowsystem/src/kwindoweffects.h, line 143 > > <http://git.reviewboard.kde.org/r/113885/diff/1/?file=214306#file214306line143> > > > > An unfortunate side effect of this is that this API becomes > > incompatible with the equivalent API on Windows. > >
so on windows the parameter would have to be a no-op, that yeah, is not beautiful - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113885/#review44042 ----------------------------------------------------------- On Nov. 15, 2013, 2:54 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113885/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2013, 2:54 p.m.) > > > Review request for kdelibs and kwin. > > > Repository: kdelibs > > > Description > ------- > > To enhance readability, not only blur the background, but if the right x > property is provided, either make the color of the pixels lighter or darker, > decreasing the contrast a lot. > This is different from just making the window more opaque, since it doesn't > cover the information about color, but just information about contrast, > making the end result better looking. > This is the kdelibs facing part of http://git.reviewboard.kde.org/r/113884/ > > > Diffs > ----- > > tier1/kwindowsystem/src/kwindoweffects.h 78195ac > tier1/kwindowsystem/src/kwindoweffects_dummy.cpp ce3b9bf > tier1/kwindowsystem/src/kwindoweffects_x11.cpp 9e3fba7 > > Diff: http://git.reviewboard.kde.org/r/113885/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
