> On Nov. 14, 2013, 2:55 p.m., Sebastian Kügler wrote: > > Nice. > > > > The QFormLayout doesn't need to be replaced, see the comment inline. > > > > Did you test if switching icons works with this? Are changes being picked > > up at run-time?
diff updated with points mentioned switching icon themes and effects works yes but the changes do not seem to be picked up at run-time also the KColorButton widgets don't seem to work, you select a colour but the widget doesn't show the selection - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113853/#review43666 ----------------------------------------------------------- On Nov. 14, 2013, 4:26 p.m., Jonathan Riddell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113853/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2013, 4:26 p.m.) > > > Review request for KDE Runtime and Sebastian Kügler. > > > Repository: kde-runtime > > > Description > ------- > > port kcm icons to Qt 5 and KF 5 > > > Diffs > ----- > > kcontrol/icons/iconthemes.h 7352c21 > kcontrol/icons/iconthemes.cpp 9899686 > kcontrol/icons/main.h 066080d > kcontrol/icons/main.cpp c98d78a > kcontrol/icons/tests/CMakeLists.txt 2199068 > kcontrol/icons/tests/testicons.cpp eae44b1 > kcontrol/icons/CMakeLists.txt b16a52b > kcontrol/icons/icons.cpp 3813651 > kcontrol/icons/icons.desktop d594788 > kcontrol/icons/icons.h 1217c99 > kcontrol/CMakeLists.txt 6e6d593 > > Diff: http://git.reviewboard.kde.org/r/113853/diff/ > > > Testing > ------- > > > Thanks, > > Jonathan Riddell > >
