----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113216/#review41617 -----------------------------------------------------------
This will not improve performance noticeably; QString is copy-on-write. - Nicolás Alvarez On Oct. 12, 2013, 9:06 a.m., Jaime Torres Amate wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113216/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2013, 9:06 a.m.) > > > Review request for KDE Runtime. > > > Repository: kde-runtime > > > Description > ------- > > A new check by cppcheck (avoid to call the copy constructor). > networkUri.serviceName() and networkUri.serviceType() and > networkUri.hostAddress() return const QString&. > > > Diffs > ----- > > kioslave/network/ioslave/networkslave.cpp a548f1a > > Diff: http://git.reviewboard.kde.org/r/113216/diff/ > > > Testing > ------- > > > Thanks, > > Jaime Torres Amate > >
