----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112848/#review41269 -----------------------------------------------------------
One thing I just noticed -- KButtonGroup is deprecated in KF5, in favour of QGroupBox + QButtonGroup. So while this is certainly good to go in, you might want to use QGroupBox+QButtonGroup in your code instead... Shall I commit it for you? AFAICS you have no git account? kdeui/widgets/kbuttongroup.h <http://git.reviewboard.kde.org/r/112848/#comment30261> this is normally indented (4 spaces) kdeui/widgets/kbuttongroup.h <http://git.reviewboard.kde.org/r/112848/#comment30262> this too - David Faure On Oct. 4, 2013, 6:37 p.m., Bruno Farias wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112848/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2013, 6:37 p.m.) > > > Review request for kdelibs. > > > Repository: kdelibs > > > Description > ------- > > - Adding new test for kbuttongroup > - Fixing kbuttongroup.cpp identation > > > Diffs > ----- > > kdeui/tests/kbuttongrouptest.h cd9130a9b0840160bdce5a1841735e2050d10a7d > kdeui/tests/kbuttongrouptest.cpp d5f9f88b839d4be88cac81c1e7d0444422dd17ea > kdeui/widgets/kbuttongroup.h de813ea95dca1247698537a966abe474fa9650cf > kdeui/widgets/kbuttongroup.cpp 4057cc023107cd76cc34590f4b1dd91e01717d3d > > Diff: http://git.reviewboard.kde.org/r/112848/diff/ > > > Testing > ------- > > All tests of KButtonGroupTest were passed > > > Thanks, > > Bruno Farias > >
