> On July 19, 2012, 9:58 p.m., Mark Gaiser wrote: > > Perhaps you could use a qDeleteAll: > > http://qt-project.org/doc/qt-4.8/qtalgorithms.html#qDeleteAll-2 ?
Sure - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105627/#review16142 ----------------------------------------------------------- On July 19, 2012, 9:08 p.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105627/ > ----------------------------------------------------------- > > (Updated July 19, 2012, 9:08 p.m.) > > > Review request for kdelibs, Frederik Gladhorn and David Faure. > > > Description > ------- > > There is a too agressive check in KWidgetItemDelegateEventListener that > complains about > "User of KWidgetItemDelegate should not delete widgets created by > createItemWidgets!" > when closing an about dialog. > > I tried making it less agressive but since i could not, i'm just deleting > things in a different order in the destruction of KAboutApplicationDialog so > that the warning is not triggered and our users get angry > > > This addresses bug 301628. > http://bugs.kde.org/show_bug.cgi?id=301628 > > > Diffs > ----- > > kdeui/dialogs/kaboutapplicationdialog.cpp 2c98f74 > > Diff: http://git.reviewboard.kde.org/r/105627/diff/ > > > Testing > ------- > > Dialog still works, valgrind doesn't complain, the warning is gone > > > Thanks, > > Albert Astals Cid > >
