----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105620/#review16134 -----------------------------------------------------------
Ship it! Good enough for 4.x (the "fully correct" way would involve creating and setting up our own QTextDocument, not worth it here). This is however a very good additional reason for having this feature in QLabel itself, in Qt-5.1. - David Faure On July 19, 2012, 1:20 p.m., Christoph Feck wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105620/ > ----------------------------------------------------------- > > (Updated July 19, 2012, 1:20 p.m.) > > > Review request for kdelibs. > > > Description > ------- > > This uses a simple regex replace to get rid of tags, not sure if any more > complex operations are worth the effort (there is always the "copy all text" > menu item). > > > This addresses bug 303780. > http://bugs.kde.org/show_bug.cgi?id=303780 > > > Diffs > ----- > > kdeui/widgets/ksqueezedtextlabel.cpp 99745d5 > > Diff: http://git.reviewboard.kde.org/r/105620/diff/ > > > Testing > ------- > > I tested with the steps from the bug report. > > > Thanks, > > Christoph Feck > >
