----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105607/#review16131 -----------------------------------------------------------
dolphin/src/dolphinpart.cpp <http://git.reviewboard.kde.org/r/105607/#comment12672> It would be more robust to turn the findFile action pointer into a member variable, and to use that here. Otherwise, future changes in createActions() could break this code here, without the compiler detecting the breakage. - David Faure On July 19, 2012, 1:59 p.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105607/ > ----------------------------------------------------------- > > (Updated July 19, 2012, 1:59 p.m.) > > > Review request for KDE Base Apps. > > > Description > ------- > > The attached patch hides the "Find File" action in Dolphin's KPart since > finding files is only supported for local protocols. It does not work for > remote protocols. See bug report listed above. > > > This addresses bug 279283. > http://bugs.kde.org/show_bug.cgi?id=279283 > > > Diffs > ----- > > dolphin/src/dolphinpart.cpp b3b7cd0 > > Diff: http://git.reviewboard.kde.org/r/105607/diff/ > > > Testing > ------- > > > Thanks, > > Dawit Alemayehu > >
