----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102038/#review15933 -----------------------------------------------------------
FYI, ksysguard.desktop now uses "KSysGuard" as "Name" and "System Monitor" as "GenericName". See https://git.reviewboard.kde.org/r/105338/. So there is no more valid reason to add the "OnlyShownIn" key for it. For systemsettings, the problem seems to be "solved" by shipping systemsettings.desktop for KDE environment and kdesystemsettings.desktop for non-KDE environment. So I think this review can be closed now. - Jekyll Wu On July 21, 2011, 10:39 p.m., Jeremy Bicha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102038/ > ----------------------------------------------------------- > > (Updated July 21, 2011, 10:39 p.m.) > > > Review request for KDE Base Apps. > > > Description > ------- > > Add OnlyShowIn:KDE line to KSysguard & SystemSettings. Otherwise, it's very > frustrating when running any other desktop (Gnome Shell, Unity, etc.) and > seeing multiple apps named the same thing with the same icon without any way > to distinguish them. > > > Diffs > ----- > > ksysguard/gui/ksysguard.desktop 7e8ff32f1e275ee246e79da039509e28e56987cf > systemsettings/app/systemsettings.desktop > 5934a194675cfe152ebdbfd4a9db45ebd48b67a8 > > Diff: http://git.reviewboard.kde.org/r/102038/diff/ > > > Testing > ------- > > > Thanks, > > Jeremy Bicha > >
