On Wed, Jun 8, 2011 at 6:05 AM, Simon Persson <simonperss...@gmail.com>wrote:
> This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101523/ > > On June 7th, 2011, 4:31 p.m., *Michael Jansen* wrote: > > Looks good but i am wondering if it wouldn't be necessary to complain about a > shortcut conflict if you try to register some shortcut with tab and the same > one with backtab is already registered? If not we could get two conflicting > shortcuts here. > > Yes, that could be a nice thing. Currently it is needed. But with this patch > applied KWin can be changed and then I don't see a great need for it, as I > said above.. the only way to get shortcuts that include backtab is to either > do it from code (the default shortcut) or by manually editing config files. > > What about users upgrading from older versions who have it stored in their config files? > If I have some time I can look at it, but it will be a separate patch. > > Should I commit this? > > > - Simon > > On June 6th, 2011, 11:24 a.m., Simon Persson wrote: > Review request for KDE Runtime and Michael Jansen. > By Simon Persson. > > *Updated June 6, 2011, 11:24 a.m.* > Description > > When entering (ctrl,alt,meta+) shift+tab as a new shortcut KKeySequenceWidget > gets "backtab" as the key pressed but records "tab", because it looks/sounds > better I guess... When either of backtab or tab is used with shift as a > shortcut in an application Qt triggers the shortcut. kglobalaccel gets the > keypress event as "backtab" which is correct but only triggers shortcuts with > "backtab" in them and such shortcuts are not possible for the user to enter > using kshortcutseditor. > > This patch makes kglobalaccel look for both tab and backtab when triggered, > same as Qt does. > > KWin should possibly be patched to have alt+shift+tab as its default > shortcut, currently it has alt+shift+backtab (which is why it works even > without this patch...). That would solve the issue that currently a user can > enter alt+shift+tab as shortcut for something else and the conflict is not > detected. > > Testing > > Tested using master branch, running in a Xephyr session. Switching between > plasma activities with meta+shift+tab now works. > > *Bugs: * 174142 <http://bugs.kde.org/show_bug.cgi?id=174142>, > 258467<http://bugs.kde.org/show_bug.cgi?id=258467>, > 261296 <http://bugs.kde.org/show_bug.cgi?id=261296>, > 274006<http://bugs.kde.org/show_bug.cgi?id=274006> > Diffs > > - kglobalaccel/globalshortcutcontext.cpp (fc2e6a6) > > View Diff <http://git.reviewboard.kde.org/r/101523/diff/> > -- Work is punishment for failing to procrastinate effectively.
