----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101515/ -----------------------------------------------------------
Review request for kdelibs and Michael Jansen. Summary ------- First of two patches to fix a set of bugs for global shortcuts involving shift key. Not sure if this can go in 4.7 because of the freeze? It adds a new function to the API for the sake of a bugfix. Prepared the following commit message: Export the function isShiftAsModifierAllowed() This function inside KKeySequnceWidgetPrivate is needed by kglobalaccel, export here rather than duplicating code and risk falling out of sync. Also add Qt::Key_Backtab to the list, this is not needed internally since there is a special case for Alt+Shift+Tab to not be recorded as Alt+Backtab but other users of this function will need it. This addresses bugs 179504, 197548 and 215030. http://bugs.kde.org/show_bug.cgi?id=179504 http://bugs.kde.org/show_bug.cgi?id=197548 http://bugs.kde.org/show_bug.cgi?id=215030 Diffs ----- kdeui/widgets/kkeysequencewidget.h b9aafdc kdeui/widgets/kkeysequencewidget.cpp a35c2b4 Diff: http://git.reviewboard.kde.org/r/101515/diff Testing ------- Thanks, Simon