----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101348/#review3605 -----------------------------------------------------------
Note that I can't really comment on the activities specific parts, Ivan would probably be a better reviewer for that parts. Anyway I found a couple of smaller issues which need fixing. kfile/kfileplacesmodel.cpp <http://git.reviewboard.kde.org/r/101348/#comment3019> Please fix the indentation of this line. Also why not providing q as parent for the activity consumer so that the delete in the dtor isn't needed anymore. kfile/kfileplacesmodel.cpp <http://git.reviewboard.kde.org/r/101348/#comment3020> Please remove the extra space after *. - Kevin On May 13, 2011, 2:30 a.m., Jeffery MacEachern wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101348/ > ----------------------------------------------------------- > > (Updated May 13, 2011, 2:30 a.m.) > > > Review request for kdelibs, Kevin Ottens and David Faure. > > > Summary > ------- > > Adds an "Only show in this Activity" option to the KFilePlaces Widget and > support in the underlying model code. Currently only "one activity"/"all > activities" are supported as choices; I think this should be sufficient, and > anything more complicated would be hard to make usable. > > > Diffs > ----- > > kfile/CMakeLists.txt ceae140 > kfile/kfileplaceeditdialog.h d5b030a > kfile/kfileplaceeditdialog.cpp d798b4d > kfile/kfileplacesmodel.h b3dd821 > kfile/kfileplacesmodel.cpp b037084 > kfile/kfileplacesview.cpp 6a343b3 > > Diff: http://git.reviewboard.kde.org/r/101348/diff > > > Testing > ------- > > Tested on Project Neon/Kubuntu Natty. Created several activities, added Place > bookmarks, set them to only show in the current activity, and switched > activities. Everything worked as intended. EDIT: one small known issue - the > OnlyInActivity setting doesn't take when the bookmark is first created; you > have to hit Edit and re-check the box. > > > Thanks, > > Jeffery > >
