----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101359/#review3507 -----------------------------------------------------------
This patch does not apply to current master. Can you recreate it? patching file fonts.cpp Hunk #1 FAILED at 328. 1 out of 1 hunk FAILED -- saving rejects to file fonts.cpp.rej patching file kxftconfig.cpp - Christoph On May 14, 2011, 2:48 a.m., Nikolaus Waxweiler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101359/ > ----------------------------------------------------------- > > (Updated May 14, 2011, 2:48 a.m.) > > > Review request for KDE Base Apps and KDE Runtime. > > > Summary > ------- > > I simply removed all code in loading routines that wrote something to the > config. > > On a side-note, I'd love to rip out the whole fontconfig configuration > completely... I think that the whole modifying-.fonts.conf-approach is too > fickle because the system/distribution can set up elaborate > hinting/antialiasing configurations and the changes made to .fonts.conf just > bulldoze over them. Most people will probably never (really want to) touch > those settings anyway (Windows and Mac OS X users at least don't seem to, and > they don't appear to be unhappy about it)... Would there even be any good > alternative approaches? > > > This addresses bug 105797. > http://bugs.kde.org/show_bug.cgi?id=105797 > > > Diffs > ----- > > kcontrol/fonts/fonts.cpp c796961 > kcontrol/fonts/kxftconfig.cpp 9cd04de > > Diff: http://git.reviewboard.kde.org/r/101359/diff > > > Testing > ------- > > - Delete .fonts.conf and see if invoking "kcmshell4 fonts" creates it again > without user intervention > - Delete various match-settings set by the kcm (e.g. hintstyle and rgba) and > see if it recreates them while leaving match-settings not deleted untouched > - Switch anti-aliasing settings between system, disbled and enabled and apply > each time, change some aa-settings while enabled and check if they stay there > after switching > > > Thanks, > > Nikolaus > >
