adridg marked 5 inline comments as done.
adridg added inline comments.
INLINE COMMENTS
> kfunk wrote in FindInotify.cmake:51
> Style: Indent off
Assuming that means "comments indent 0" and not "comments indentation should
match surrounding indent, which is 4". It's a bit ambiguous.
> kfunk wrote in FindInotify.cmake:54
> Set `Inotify_LIBRARIES` & `Inotify_INCLUDE_DIRS` to empty string?
Yes, good point -- since the instructions will be to add
${Inotify_INCLUDE_DIRS} to the include path, they must be set to avoid warnings.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D3826
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: adridg, apol, arrowdodger, #buildsystem, #frameworks, tcberner, ervin,
skelly, dfaure, kfunk
Cc: kfunk, #freebsd
