https://bugs.kde.org/show_bug.cgi?id=493376

Akseli Lahtinen <akse...@akselmo.dev> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |https://invent.kde.org/plas
                   |                            |ma/plasma-desktop/-/commit/
                   |                            |f7a92f7e65ac09cfd82a01835ac
                   |                            |9f955c1b25744

--- Comment #11 from Akseli Lahtinen <akse...@akselmo.dev> ---
Git commit f7a92f7e65ac09cfd82a01835ac9f955c1b25744 by Akseli Lahtinen.
Committed on 13/11/2024 at 12:51.
Pushed by akselmo into branch 'master'.

FolderView: Performance improvements for selections

This MR has multiple changes, especially related to the "rubberband" (selection
rectangle).

- Use `Qt.callLater` for `gridView.rectangleSelect` to eliminate redundant
calls.
  - This was previously called *every time mouse moved one pixel*
- Clear a redundant mapToItem
  - `var cPos = mapToItem(gridView.contentItem, mouse.x, mouse.y);` needs to be
only called during rubberband action
- Update dragItem images after selection is done, instead of every time a
delegate is selected
- Instead of creating and destroying `selectionButton` in `FolderItemDelegate`,
create it once and toggle its visibility


These all should help with the performance related to selecting multiple icons
by dragging the selectiong rectangle around them.

M  +13   -17   containments/desktop/package/contents/ui/FolderItemDelegate.qml
M  +26   -9    containments/desktop/package/contents/ui/FolderView.qml
M  +5    -0    containments/desktop/plugins/folder/foldermodel.cpp
M  +1    -0    containments/desktop/plugins/folder/foldermodel.h

https://invent.kde.org/plasma/plasma-desktop/-/commit/f7a92f7e65ac09cfd82a01835ac9f955c1b25744

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to